Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License userspace with with Apache-2.0, and BPF with Dual BSD-2 and GPL-2.0 #190

Merged
merged 1 commit into from
Jul 6, 2023
Merged

License userspace with with Apache-2.0, and BPF with Dual BSD-2 and GPL-2.0 #190

merged 1 commit into from
Jul 6, 2023

Conversation

brb
Copy link
Member

@brb brb commented Jun 6, 2023

It's required as part of the ongoing CNCF donation.

cc @lizrice

@brb brb requested review from gandro, tklauser and aditighag June 6, 2023 14:35
@gandro
Copy link
Member

gandro commented Jun 6, 2023

Doesn't such a change require approval from all contributors? For cilium/cilium#18858 we contacted all of them individually.

@brb
Copy link
Member Author

brb commented Jun 6, 2023 •
edited
Loading

@ur4t @Asphaltt @duanjiong @twpayne @chendotjs @dezmodue @kdrag0n @PMaynard @pgampe @sterchelen @msherif1234 @varunkumare99 @anubhabMajumdar @jauderho @Shikugawa @ypl-coffee @szuecs @mfrw Could you please ACK?

@brb brb requested a review from YutaroHayakawa June 6, 2023 15:06
@twpayne
Copy link
Contributor

twpayne commented Jun 6, 2023

ACK

1 similar comment
@sterchelen
Copy link
Contributor

ACK

twpayne
twpayne reviewed Jun 6, 2023
View reviewed changes
Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md needs updating as well in the Contributing section.

@brb brb requested a review from twpayne June 6, 2023 15:44
@dezmodue
Copy link
Contributor

dezmodue commented Jun 6, 2023

ACK

1 similar comment
@kdrag0n
Copy link
Contributor

kdrag0n commented Jun 6, 2023

ACK

tklauser
tklauser approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

YutaroHayakawa
YutaroHayakawa approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

gandro
gandro approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@lizrice
Copy link
Member

lizrice commented Jun 7, 2023 •
edited
Loading

Sorry - I've realised that what we need is even more complicated. CNCF user space code needs to be Apache-2.0; we're hoping to get an exception allowing for eBPF programs in the kernel to be dual-licensed GPL-2.0/BSD. (Apologies for not making this clearer - it was pointed out to me that pwru was GPL, but I didn't actually look and assumed they were just talking about the kernel code.)

@szuecs
Copy link
Contributor

szuecs commented Jun 7, 2023

@brb ACK, also for a change to Apache-2.0 license in case this will be done.

@PMaynard
Copy link
Contributor

PMaynard commented Jun 7, 2023

ACK

@brb brb changed the title Dual license with GPL-2.0 and BSD-2 License with Apache-2.0 Jun 8, 2023
@brb
Copy link
Member Author

brb commented Jun 8, 2023

@lizrice No worries, updated to Apache-2.0.

YutaroHayakawa
YutaroHayakawa approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ur4t
Copy link
Contributor

ur4t commented Jun 9, 2023

ACK

@brb brb changed the title License with Apache-2.0 License userspace with with Apache-2.0, and BPF with Dual BSD-2 and GPL-2.0 Jun 9, 2023
tklauser
tklauser approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks!

@pgampe
Copy link
Contributor

pgampe commented Jun 10, 2023

belated ACK (not sure why I was tagged as approver)

@brb
Copy link
Member Author

brb commented Jun 23, 2023

@jauderho Could you approve the PR?

@msherif1234
Copy link
Contributor

ACK

1 similar comment
@Shikugawa
Copy link
Contributor

ACK

@jauderho
Copy link
Contributor

@jauderho Could you approve the PR?

ACK

@varunkumare99
Copy link
Contributor

ACK

@brb
Copy link
Member Author

brb commented Jun 27, 2023

@duanjiong @chendotjs @anubhabMajumdar @ypl-coffee Could you ACK?

@brb brb requested review from lmb and jschwinger233 and removed request for sterchelen June 30, 2023 09:40
@brb
Change licenses
41e5f17 
Dual-license bpf/ with BSD-2 and GPL-2.0, and userspace with Apache-2.0.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb mentioned this pull request Jul 3, 2023
Merged
lmb
lmb approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@anubhabMajumdar
Copy link
Contributor

ACK

@brb
Copy link
Member Author

brb commented Jul 6, 2023

Missing ACKs are from @duanjiong @chendotjs @ypl-coffee. I tried to reach them through different channels, but I haven't received any response. Considering that majority ACKs are in, merging the PR.

@brb brb merged commit 5f366c5 into main Jul 6, 2023
3 of 4 checks passed
brb added a commit that referenced this pull request Feb 28, 2024
@brb
Change license of build.go to Apache-2
8d09856 
Apache-2 has been used by all modules in the project.

Related: #190

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb mentioned this pull request Feb 28, 2024
Merged
brb added a commit that referenced this pull request Mar 1, 2024
@brb
Change license of build.go to Apache-2
4ee0356 
Apache-2 has been used by all modules in the project.

Related: #190

Signed-off-by: Martynas Pumputis <m@lambda.lt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twpayne twpayne twpayne approved these changes

@gandro gandro gandro approved these changes

@lmb lmb lmb approved these changes

@tklauser tklauser tklauser approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@sterchelen sterchelen sterchelen approved these changes

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.