Run release build as regular user #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobias Klauser <tobias@cilium.io>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
Instead of adding the checkout directory to git's safe directories as done in commit 1d42d3f ("make: allow running git status during release build"), change the release target to create a regular user with the same UID/GID as the current user (assumed to be the user owning the working directory) inside the container and use it to run `make release`. Follows cilium/hubble#751 and cilium/cilium-cli#945 Signed-off-by: Tobias Klauser <tobias@cilium.io>
gandro
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the approach taken in cilium/hubble and cilium/cilium-cli
make releasetargets, see cilium/hubble#751 and cilium/cilium-cli#945.Also update Go and alpine to the most recent versions and add the
release/directory to.gitignore.