Add _total suffix to counter metrics that didn't have it #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lambdanis
force-pushed
the
pr/lambdanis/counters-total
branch
2 times, most recently
from
d4cf298
to
0d8baee
Compare
Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/counters-total
branch
2 times, most recently
from
709952b
to
a5a3357
Compare
To tetragon_event_cache_accesses_total. The new name follows the OpenMetrics standard and common conventions. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
To tetragon_policy_events_total. The new name follows the OpenMetrics standard and common conventions. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
To tetragon_syscalls_total. The new name follows the OpenMetrics standard and common conventions. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
For compatibility with the OpenMetrics standard: https://github.com/OpenObservability/OpenMetrics/blob/v1.0.0/specification/OpenMetrics.md#suffixes This is a breaking change, but it shouldn't be painful - the semantics of the metrics doesn't change, only the names. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/counters-total
branch
from
a5a3357
to
d6b4e3e
Compare
kkourt
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with the OpenMetrics standard. This is a breaking change, but it shouldn't be painful - the semantics of the
metrics doesn't change, only the names.
While here, I renamed a few metrics to follow common naming conventions:
Admittedly, it's also not super necessary - using plain Prometheus you can scrape and query existing metrics just fine. Maybe there are/will be other systems that are pedantic about the standard, then this change will bring some benefits, but otherwise it's kinda compatibility for its own sake. Please shout if you think it's not worth it, but IMO this change is innocent enough to do it :)
I also removed unused label value constants from the
errormetricspackage. Let me know if I shouldn't do that - these vars are exported, but not used anywhere.