renovate: fix renovate upgrade of Go toolchain #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #1536 broke "renovate update Go toolchain in a single PR" from #1259 because in the actual state it could only bump the go directive from minor versions, not bumping the patch needed by the workflows github actions reading that version. From cilium/cilium@2f7e2f3: According to [1] as of Go 1.21 we either need to specify the full toolchain version in the `go` directive or add a `toolchain` directive with the concrete toolchain version. Opt for the former and make sure it's kept up to date by renovate bot. [1] golang/go#62278 (comment) Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
added
area/ci
mtardy
requested review from
tixxdz,
kkourt,
willfindlay and
michi-covalent
and removed request for
tixxdz
willfindlay
approved these changes
Oct 11, 2023
|
Thanks that was fast, hopefully, this works! :) We'll see here #1577 |
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Oct 18, 2023
Configure Renovate to update Go version in go.mod, and modify workflow files to use go.mod to get the Go version to reduce the number of places Renovate needs to update. Ref: cilium/tetragon#1579 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1536 broke "renovate update Go toolchain in a single PR" from #1259 because in the actual state it could only bump the go directive from minor versions, not bumping the patch needed by the workflows github actions reading that version.
From cilium/cilium@2f7e2f3: According to [1] as of Go 1.21 we either need to specify the full toolchain version in the
godirective or add atoolchaindirective with the concrete toolchain version. Opt for the former and make sure it's kept up to date by renovate bot.[1] golang/go#62278 (comment)