-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update docker.io/golangci/golangci-lint docker tag to v1.56.1 (main) #2080
chore(deps): update docker.io/golangci/golangci-lint docker tag to v1.56.1 (main) #2080
Conversation
….56.1 Signed-off-by: cilium-renovate[bot] <134692979+cilium-renovate[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just fixing some new issues that cropped up
c1d6d28
to
cfa6ccb
Compare
The default settings can hide existing issues until older ones are fixed, which leads to a really frustrating back-and-forth with CI trying to get all outstanding issues fixed. Signed-off-by: William Findlay <will@isovalent.com>
cfa6ccb
to
de75ab1
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@@ -309,7 +309,7 @@ func tetragonExecute() error { | |||
log.Infof("Received signal SIGRTMIN+22: resetting original LogLevel '%s'", logger.GetLogLevel()) | |||
} | |||
} | |||
}(obs) | |||
}() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter got that? 😮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It got it but I had to fix it manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
@@ -1032,7 +1032,7 @@ func dnsLookup(fqdn string) { | |||
// We fire and forget DNS lookups, and we don't care if they hit or not. | |||
res := &net.Resolver{ | |||
PreferGo: true, | |||
Dial: func(ctx context.Context, network, address string) (net.Conn, error) { | |||
Dial: func(_ context.Context, _, _ string) (net.Conn, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahah this is cursed
This PR contains the following updates:
v1.55.2
->v1.56.1
Configuration
📅 Schedule: Branch creation - "on monday and friday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.