Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update docker.io/golangci/golangci-lint docker tag to v1.56.1 (main) #2080

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

cilium-renovate[bot]
Copy link
Contributor

This PR contains the following updates:

Package Update Change
docker.io/golangci/golangci-lint minor v1.55.2 -> v1.56.1

Configuration

📅 Schedule: Branch creation - "on monday and friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

….56.1

Signed-off-by: cilium-renovate[bot] <134692979+cilium-renovate[bot]@users.noreply.github.com>
@cilium-renovate cilium-renovate bot requested review from willfindlay and a team as code owners February 9, 2024 11:06
@cilium-renovate cilium-renovate bot added release-blocker This PR or issue is blocking the next release. release-note/dependency This PR updates one or multiple dependencies labels Feb 9, 2024
Copy link
Contributor

@willfindlay willfindlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fixing some new issues that cropped up

@willfindlay willfindlay force-pushed the renovate/main-docker.io-golangci-golangci-lint-1.x branch 5 times, most recently from c1d6d28 to cfa6ccb Compare February 13, 2024 16:28
The default settings can hide existing issues until older ones are fixed, which leads to
a really frustrating back-and-forth with CI trying to get all outstanding issues fixed.

Signed-off-by: William Findlay <will@isovalent.com>
Signed-off-by: William Findlay <will@isovalent.com>
@willfindlay willfindlay force-pushed the renovate/main-docker.io-golangci-golangci-lint-1.x branch from cfa6ccb to de75ab1 Compare February 13, 2024 16:53
@cilium-renovate
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@mtardy mtardy self-requested a review February 13, 2024 17:37
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@@ -309,7 +309,7 @@ func tetragonExecute() error {
log.Infof("Received signal SIGRTMIN+22: resetting original LogLevel '%s'", logger.GetLogLevel())
}
}
}(obs)
}()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter got that? 😮

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got it but I had to fix it manually

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@@ -1032,7 +1032,7 @@ func dnsLookup(fqdn string) {
// We fire and forget DNS lookups, and we don't care if they hit or not.
res := &net.Resolver{
PreferGo: true,
Dial: func(ctx context.Context, network, address string) (net.Conn, error) {
Dial: func(_ context.Context, _, _ string) (net.Conn, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahah this is cursed

@mtardy mtardy merged commit 82c3699 into main Feb 14, 2024
32 checks passed
@mtardy mtardy deleted the renovate/main-docker.io-golangci-golangci-lint-1.x branch February 14, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker This PR or issue is blocking the next release. release-note/dependency This PR updates one or multiple dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants