Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: Factor uprobe sensor setup #2085

Merged
merged 2 commits into from
Feb 12, 2024
Merged

tetragon: Factor uprobe sensor setup #2085

merged 2 commits into from
Feb 12, 2024

Conversation

olsajiri
Copy link
Contributor

@olsajiri olsajiri commented Feb 11, 2024

after talking to ebpf/cilium maintainers, new release might still take a while,
so pushing at least the generic refactoring change from #1914 so it won't get old

Separating uprobe sensor setup into addUprobe function, that creates and sets up uprobeEntry object and createSingleUprobeSensor that creates the actual sensor progs/maps arrays.

This way we can easily add multi uprobe sensor create function in following changes.

@olsajiri olsajiri added the release-note/minor This PR introduces a minor user-visible change label Feb 11, 2024
Separating uprobe sensor setup into addUprobe function, that creates
and sets up uprobeEntry object and createSingleUprobeSensor that
creates the actual sensor progs/maps arrays.

This way we can easily add multi uprobe sensor create function in
following changes.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@olsajiri olsajiri marked this pull request as ready for review February 11, 2024 23:12
@olsajiri olsajiri requested a review from a team as a code owner February 11, 2024 23:12
Just to keep it consistent. At the moment we don't use the return
value to trigger the return probe, but it's the plan for the future.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Copy link
Contributor

@kevsecurity kevsecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olsajiri olsajiri merged commit 2ec3cfb into main Feb 12, 2024
36 checks passed
@olsajiri olsajiri deleted the pr/olsajiri/uprobe_fix branch February 12, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants