tetragon: Rename killer to enforcer #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
added
the
release-note/minor
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
olsajiri
force-pushed
the
pr/olsajiri/enforcer
branch
from
9c631e0
to
903b2dc
Compare
olsajiri
force-pushed
the
pr/olsajiri/enforcer
branch
3 times, most recently
from
c21825b
to
8b1a7ab
Compare
kkourt
approved these changes
Feb 23, 2024
| if err := col.unload(); err != nil { | ||
| errs = errors.Join(errs, err) | ||
| } | ||
| col.destroy() |
There was a problem hiding this comment.
yep indeed this is a miss on my part thanks. The destroy hook was added in contrast to the unload one that was used when enabling/disabling vs removing completely the sensor. Allowing us to clean up stuff only when it's really removed and not only disabled.
There was a problem hiding this comment.
Sounds good. Can you please ACK the PR if you agree with the change?
There was a problem hiding this comment.
Too late but yes I agreed with the change
The [0] commit added sensor's destroy hook and changed kprobe logic to cleanup genericKprobeTable in there. We also need to change removeAllSensors to do destroy instead of unload so the kprobe hook is executed. [0] 70e4fcd ("pkg/sensors: cleanup kprobe entry from table on destroy") Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Renaming NOTIFYKILLER to NOTIFYENFORCER action as a first step of the whole rename, so we have schema changes separated. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Renaming killer bpf sensor to enforcer including the file object names. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Renaming killer spec to enforcer to have the spec changes separated. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Renaming killer go code to enforcer. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Renaming killer go objects to enforcer. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Renaming killer-tester to enforcer-tester. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/enforcer
branch
from
8b1a7ab
to
2473217
Compare
|
This PR contains a breaking change to a CRD, so I labeled it as such. @olsajiri could you write in the release note which fields changed? |
lambdanis
removed
the
release-note/minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename all the killer stuff to enforcer, plus one simple sensors fix