-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: Update vagrant configuration #2413
Conversation
This is to support a bigger vagrant instance locally Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to avoid the below issue, small refactor is also done. ``` vagrant@ubuntu-jammy:~/go/src/github.com/cilium/tetragon$ make test make -C "contrib/tester-progs" make[1]: Entering directory '/home/vagrant/go/src/github.com/cilium/tetragon/contrib/tester-progs' go build -o lseek-pipe ./go/lseek-pipe go: errors parsing go.mod: /home/vagrant/go/src/github.com/cilium/tetragon/go.mod:4: invalid go version '1.22.0': must match format 1.23 make[1]: *** [Makefile:87: lseek-pipe] Error 1 make[1]: Leaving directory '/home/vagrant/go/src/github.com/cilium/tetragon/contrib/tester-progs' make: *** [Makefile:416: tester-progs] Error 2 ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
# Install golang | ||
GO_VERSION=$1 | ||
curl -O https://storage.googleapis.com/golang/go$GO_VERSION.linux-amd64.tar.gz && \ | ||
rm -rf /usr/local/go \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to delete existing go on users. This is on the host?
Could we check if go version is correct first and then give a readable warning with instructions on how to do this? And/or prompt to replace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, just commenting since I think we don't use Vagrant for any of the CI tests. So it's a development thing I don't think one many people use.
However, I have no objection to merge this since it might be well outdated but it's not well tested and thus not maintained so maybe we could discuss removing it?
Ah thanks both 👍 |
Description
Pleases refer to individual commit for more details.
Testing
Testing was done locally with
make test
after VM provision as per below