Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: Add bpf program loader tests #244

Merged
merged 6 commits into from
Aug 16, 2022
Merged

Conversation

olsajiri
Copy link
Contributor

@olsajiri olsajiri commented Jul 18, 2022

Adding CheckSensorLoad function that takes array of programs
and maps and checks they are loaded and share specified maps.

Plus related changes to allow that.

Signed-off-by: Jiri Olsa jolsa@kernel.org

@olsajiri olsajiri force-pushed the loader/tests branch 6 times, most recently from 1038261 to d202145 Compare July 25, 2022 08:09
@olsajiri olsajiri force-pushed the loader/tests branch 5 times, most recently from c1ff15f to d8a0602 Compare August 7, 2022 22:10
@olsajiri olsajiri force-pushed the loader/tests branch 9 times, most recently from 2f4969f to f9ef5e6 Compare August 11, 2022 06:39
@olsajiri olsajiri changed the title tetragon: Add bpf program loader test tetragon: Add bpf program loader tests Aug 11, 2022
@olsajiri olsajiri force-pushed the loader/tests branch 4 times, most recently from 4474e63 to c18c0dd Compare August 11, 2022 13:21
@olsajiri olsajiri marked this pull request as ready for review August 11, 2022 20:39
@olsajiri olsajiri requested a review from a team as a code owner August 11, 2022 20:39
@olsajiri olsajiri requested a review from kaworu August 11, 2022 20:39
@kaworu kaworu removed their request for review August 12, 2022 09:58
@olsajiri olsajiri force-pushed the loader/tests branch 2 times, most recently from 0a5c10a to 8470a5d Compare August 16, 2022 07:19
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM! This is definitely needed.

I have some comments. None of them is a blocker, but might be worthwhile discussing them before merging.

pkg/sensors/program/coll.go Show resolved Hide resolved
pkg/sensors/program/coll.go Outdated Show resolved Hide resolved
pkg/sensors/program/coll.go Outdated Show resolved Hide resolved
pkg/sensors/program/coll.go Show resolved Hide resolved
pkg/observer/observer.go Outdated Show resolved Hide resolved
Adding GetDefaultSensorsWithFile function to return sensors
instead of observer object. It will be used in following tests.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding LoadedCollection object to carry loaded programs/maps for
program  to be used later for TestLoad* tests to verify loaded
programs and maps.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding CheckSensorLoad function that takes array of programs
and maps and checks they are loaded and share specified maps.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding load test for initial sensors.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding load test for generic kprobe sensors.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding load test for generic tracepoint sensors.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@jrfastab jrfastab merged commit b9df5d3 into cilium:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants