tetragon: unify eventcache and execcache #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This naming convention makes more sense since only Msg types implement this interface. It also opens the door to adding additional interfaces to notify.go. Signed-off-by: William Findlay <will@isovalent.com>
Signed-off-by: William Findlay <will@isovalent.com>
We weren't using the labels from Cilium, so let's remove them. These can be added back later easily enough if we end up needing them. Rather than using a generic interface, use notify.Event and notify.Message. This also helps us avoid some unnecessary interface casting later in the event handler. Signed-off-by: William Findlay <will@isovalent.com>
In preparation for merging eventcache with execcache, let's unify the metrics here. Signed-off-by: William Findlay <will@isovalent.com>
An earlier find and replace error resulted in some instances of "TETRAGON", let's clean up them. Signed-off-by: William Findlay <will@isovalent.com>
There's no need to have two caches here and unifying them will greatly simplify the code and reduce the possibility to make errors such as the one fixed in 54856c9. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
force-pushed
the
pr/willfindlay/unify-execcache
branch
from
cc61ba5
to
50f5de8
Compare
mountPath was unused and our static checks were complaining. Let's get rid of it. Signed-off-by: William Findlay <will@isovalent.com>
|
I like the direction so I'll merge it I see at least a couple issues remaining but will merge this and then work out any fallout with @tpapagian in the next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't necessary to split execcache and eventcache so let's fold it all into eventcache. See individual commits.