Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/kind: Make install-tetragon.sh script more portable #2682

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

lambdanis
Copy link
Contributor

  1. Allow using custom Helm chart in install-tetragon.sh. A custom Helm chart can be passed via TETRAGON_KIND_HELM_CHART envvar. This is useful for testing released charts or custom distributions
  2. Make install-tetragon.sh script runnable from anywhere. There were two issues when running script from a location different than the repo root:
    • If running from a different git repo, the project root is detected incorrectly and the script fails to find config
    • If passing a relative path to a values file, the script fails to find it

Ref #1849

A custom Helm chart can be passed via TETRAGON_KIND_HELM_CHART envvar. This is
useful for testing released charts or custom distributions.

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
There were two issues when running script from a location different than the
repo root:
* If running from a different git repo, the project root is detected
  incorrectly and the script fails to find config
* If passing a relative path to a values file, the script fails to find it

Both are fixed here.

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
@lambdanis lambdanis added the release-note/misc This PR makes changes that have no direct user impact. label Jul 16, 2024
@lambdanis lambdanis requested a review from a team as a code owner July 16, 2024 21:33
@lambdanis lambdanis requested a review from jrfastab July 16, 2024 21:33
@lambdanis lambdanis merged commit 2ece34d into cilium:main Jul 17, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants