btf: improve logging around BTF files lookup #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tixxdz
force-pushed
the
pr/tixxdz/log-btf-metadata
branch
3 times, most recently
from
9411695
to
7a26e68
Compare
Tetragon needs btf to work so let's be explicit if it did find or not btf files, less confusion to users and developers. Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Improve logging message so it shows the real location of BTF file that is being used. Using Config.BTF is not sufficient as it can be empty not set, where Tetragon auto discovered the real location of the BTF file, so use that instead. Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
We have already looked up the btf file and it is saved inside btfFile of the btf package, so just ignore this argument which is bogus anyway as it can be nil. Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
tixxdz
force-pushed
the
pr/tixxdz/log-btf-metadata
branch
from
263d05a
to
a5fbef9
Compare
|
thanks @olsajiri ! fixed tests as it seems btf file is under /boot/ and we have some env sets, all pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users and even developers may get confused on why Tetragon is not working or did it find the appropriate BTF files. Improve logging and reduce confusion
Signed-off-by: Djalal Harouni tixxdz@gmail.com