ci/formatting: various improvements #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are annoying so turn them off. Signed-off-by: William Findlay <will@isovalent.com>
This is annoying, so let's disable it and let developers use a few extra characters per at their discretion. Signed-off-by: William Findlay <will@isovalent.com>
Some recent changes to the clang format configs, so we need to run make format to pick them up. Signed-off-by: William Findlay <will@isovalent.com>
We are using trace_printk in some contexts to prevent clang from making unwanted optimizations. To prevent these from being flagged as false positives, let's ignore this lint. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
force-pushed
the
pr/willfindlay/remove-line-limit
branch
from
e0bb65c
to
cc5fd81
Compare
willfindlay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.