pkg/encoder: make customized syscalls printers portable and add open/openat #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
kind/enhancement
jrfastab
reviewed
Apr 7, 2023
pkg/encoder/encoder.go
Outdated
| @@ -184,13 +184,27 @@ func (p *CompactEncoder) EventToString(response *tetragon.GetEventsResponse) (st | |||
| } | |||
| return CapTrailorPrinter(fmt.Sprintf("%s %s %s %v", event, processInfo, file, bytes), caps), nil | |||
| case "fd_install": | |||
| event := p.Colorer.Blue.Sprintf("📬 %-7s", "open") | |||
| event := p.Colorer.Blue.Sprintf("📬 %-7s", "fd_install") | |||
There was a problem hiding this comment.
We dd this intentionally with the idea that fd_install is the correct hook to monitor for file "open" events.
There was a problem hiding this comment.
put this in its own PR if we want to debate this. Then we can merge the rest of this more or less now.
mtardy
force-pushed
the
pr/mtardy/tetra-encoder
branch
from
9088476
to
f6a44eb
Compare
Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
force-pushed
the
pr/mtardy/tetra-encoder
branch
2 times, most recently
from
5f58468
to
2404a87
Compare
Rename the output for fd_install to fd_install instead of open and change the default emoji for unrecognized symbols since previous emoji was shifting alignment. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
force-pushed
the
pr/mtardy/tetra-encoder
branch
from
2404a87
to
ab91a47
Compare
kkourt
approved these changes
Apr 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename the output for fd_install to fd_install instead of open and change the default emoji for unrecognized symbols since previous emoji was shifting alignment.