Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/encoder: make customized syscalls printers portable and add open/openat #900

Merged
merged 2 commits into from
Apr 11, 2023
Merged

pkg/encoder: make customized syscalls printers portable and add open/openat #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c81f2
pkg/encoder: make customized syscalls printers portable
mtardy Apr 7, 2023
ab91a47
pkg/encoder: add custom printers for open and openat
mtardy Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/arch/arch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,13 @@ func AddSyscallPrefixTestHelper(t *testing.T, symbol string) string {
}
return syscallName
}

// CutSyscallPrefix removes a potential arch specific prefix from the symbol
func CutSyscallPrefix(symbol string) string {
for _, prefix := range supportedArchPrefix {
if strings.HasPrefix(symbol, prefix) {
return symbol[len(prefix):]
}
}
return symbol
}
35 changes: 25 additions & 10 deletions pkg/encoder/encoder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"io"

"github.com/cilium/tetragon/api/v1/tetragon"
"github.com/cilium/tetragon/pkg/arch"
"github.com/cilium/tetragon/pkg/logger"
"github.com/cilium/tetragon/pkg/syscallinfo"
)
Expand Down Expand Up @@ -159,8 +160,8 @@ func (p *CompactEncoder) EventToString(response *tetragon.GetEventsResponse) (st
return "", ErrMissingProcessInfo
}
processInfo, caps := p.Colorer.ProcessInfo(response.NodeName, kprobe.Process)
switch kprobe.FunctionName {
case "__x64_sys_write":
switch arch.CutSyscallPrefix(kprobe.FunctionName) {
case "sys_write":
event := p.Colorer.Blue.Sprintf("📝 %-7s", "write")
file := ""
if len(kprobe.Args) > 0 && kprobe.Args[0] != nil && kprobe.Args[0].GetFileArg() != nil {
Expand All @@ -171,7 +172,7 @@ func (p *CompactEncoder) EventToString(response *tetragon.GetEventsResponse) (st
bytes = p.Colorer.Cyan.Sprint(kprobe.Args[2].GetSizeArg(), " bytes")
}
return CapTrailorPrinter(fmt.Sprintf("%s %s %s %v", event, processInfo, file, bytes), caps), nil
case "__x64_sys_read":
case "sys_read":
event := p.Colorer.Blue.Sprintf("📚 %-7s", "read")
file := ""
if len(kprobe.Args) > 0 && kprobe.Args[0] != nil && kprobe.Args[0].GetFileArg() != nil {
Expand All @@ -189,14 +190,28 @@ func (p *CompactEncoder) EventToString(response *tetragon.GetEventsResponse) (st
file = p.Colorer.Cyan.Sprint(kprobe.Args[1].GetFileArg().Path)
}
return CapTrailorPrinter(fmt.Sprintf("%s %s %s", event, processInfo, file), caps), nil
case "__x64_sys_close":
case "sys_openat":
event := p.Colorer.Blue.Sprintf("📬️ %-7s", "openat")
file := ""
if len(kprobe.Args) > 1 && kprobe.Args[1] != nil {
file = p.Colorer.Cyan.Sprint(kprobe.Args[1].GetStringArg())
}
return CapTrailorPrinter(fmt.Sprintf("%s %s %s", event, processInfo, file), caps), nil
case "sys_open":
event := p.Colorer.Blue.Sprintf("📬️ %-7s", "open")
file := ""
if len(kprobe.Args) > 1 && kprobe.Args[1] != nil {
file = p.Colorer.Cyan.Sprint(kprobe.Args[1].GetStringArg())
}
return CapTrailorPrinter(fmt.Sprintf("%s %s %s", event, processInfo, file), caps), nil
case "sys_close":
event := p.Colorer.Blue.Sprintf("📪 %-7s", "close")
file := ""
if len(kprobe.Args) > 0 && kprobe.Args[0] != nil && kprobe.Args[0].GetFileArg() != nil {
file = p.Colorer.Cyan.Sprint(kprobe.Args[0].GetFileArg().Path)
}
return CapTrailorPrinter(fmt.Sprintf("%s %s %s", event, processInfo, file), caps), nil
case "__x64_sys_mount":
case "sys_mount":
event := p.Colorer.Blue.Sprintf("💾 %-7s", "mount")
src := ""
if len(kprobe.Args) > 0 && kprobe.Args[0] != nil {
Expand All @@ -207,18 +222,18 @@ func (p *CompactEncoder) EventToString(response *tetragon.GetEventsResponse) (st
dst = p.Colorer.Cyan.Sprint(kprobe.Args[1].GetStringArg())
}
return CapTrailorPrinter(fmt.Sprintf("%s %s %s %s", event, processInfo, src, dst), caps), nil
case "__x64_sys_setuid":
case "sys_setuid":
event := p.Colorer.Blue.Sprintf("🔑 %-7s", "setuid")
uid := ""
if len(kprobe.Args) > 0 && kprobe.Args[0] != nil {
uidInt := p.Colorer.Cyan.Sprint(kprobe.Args[0].GetIntArg())
uid = string(uidInt)
}
return CapTrailorPrinter(fmt.Sprintf("%s %s %s", event, processInfo, uid), caps), nil
case "__x64_sys_clock_settime":
case "sys_clock_settime":
event := p.Colorer.Blue.Sprintf("⏰ %-7s", "clock_settime")
return CapTrailorPrinter(fmt.Sprintf("%s %s", event, processInfo), caps), nil
case "__x64_sys_pivot_root":
case "sys_pivot_root":
event := p.Colorer.Blue.Sprintf("💾 %-7s", "pivot_root")
src := ""
if len(kprobe.Args) > 0 && kprobe.Args[0] != nil {
Expand All @@ -232,7 +247,7 @@ func (p *CompactEncoder) EventToString(response *tetragon.GetEventsResponse) (st
case "proc_exec_connector":
event := p.Colorer.Blue.Sprintf("🔧 %-7s", "proc_exec_connector")
return CapTrailorPrinter(fmt.Sprintf("%s %s", event, processInfo), caps), nil
case "__x64_sys_setns":
case "sys_setns":
netns := ""
event := p.Colorer.Blue.Sprintf("🔧 %-7s", "setns")
if len(kprobe.Args) > 1 && kprobe.Args[1] != nil {
Expand Down Expand Up @@ -293,7 +308,7 @@ func (p *CompactEncoder) EventToString(response *tetragon.GetEventsResponse) (st
}
return CapTrailorPrinter(fmt.Sprintf("%s %s %s", event, processInfo, attr), caps), nil
default:
event := p.Colorer.Blue.Sprintf("⁉️ %-7s", "syscall")
event := p.Colorer.Blue.Sprintf("❓ %-7s", "syscall")
return CapTrailorPrinter(fmt.Sprintf("%s %s %s", event, processInfo, kprobe.FunctionName), caps), nil
}
case *tetragon.GetEventsResponse_ProcessTracepoint:
Expand Down
3 changes: 2 additions & 1 deletion pkg/encoder/encoder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,8 @@ func TestCompactEncoder_KprobeEventToString(t *testing.T) {
},
})
assert.NoError(t, err)
assert.Equal(t, "⁉️ syscall kube-system/tetragon /usr/bin/curl unhandled_function", result)
assert.Equal(t, "❓ syscall kube-system/tetragon /usr/bin/curl unhandled_function", result)

}

func TestCompactEncoder_KprobeOpenEventToString(t *testing.T) {
Expand Down