Don't access WHOIS data before checking for failure

cinchrb · Oct 23, 2015 · 4d7e8cc · 4d7e8cc
1 parent 837c8cb
commit 4d7e8cc
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/lib/cinch/user.rb b/lib/cinch/user.rb
@@ -276,6 +276,16 @@ def whois
     # @since 1.0.1
     def end_of_whois(values)
       @in_whois = false
+      if values.nil?
+        # for some reason, we did not receive user information. one
+        # reason is freenode throttling WHOIS
+        Thread.new do
+          sleep 2
+          refresh
+        end
+        return
+      end
+
       if values[:unknown?]
         sync(:unknown?, true, true)
         self.online = false
@@ -293,16 +303,6 @@ def end_of_whois(values)
         return
       end
 
-      if values.nil?
-        # for some reason, we did not receive user information. one
-        # reason is freenode throttling WHOIS
-        Thread.new do
-          sleep 2
-          refresh
-        end
-        return
-      end
-
       if values[:registered]
         values[:authname] ||= self.nick
         values.delete(:registered)