Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional GStreamer support on MSW. #2044

Merged
merged 2 commits into from
Nov 3, 2018

Conversation

PetrosKataras
Copy link
Contributor

This PR supersedes #1947 and adds support on MSW for video playback with GStreamer on top of the latest GstPlayer fixes ( #2039 ).

@richardeakin
Copy link
Collaborator

Fired this up this evening and working quite well. I'm up for merging to keep things rolling along, however I wanted to note that I'm seeing some heavy stuttering when I switch the window to full screen (all videos I play). Fullscreen issues are typical of other video backends too (WMF comes to mind), and I'm not sure if it is a new issue (I briefly remember testing fullscreen before but I'm only noticing this now).

In any event @PetrosKataras let me know if you're ready to merge and I'll hit the green button.

@PetrosKataras
Copy link
Contributor Author

Do you mean that once you switch to fullscreen there is from then on continuous heavy stuttering during playback which disappears if you switch back to window mode? I haven't tried switching between fullscreen-window mode on Windows with the player to be honest and I m away from a Windows PC currently but I haven't seen this on neither macOS or Linux. Could this be a Windows/driver/vsync specific issue?

A couple of things to try:

  • Does it stutter if you start the application directly on fullscreen?
  • Does it stutter if you disable the frame rate limiter and you let only vertical sync enabled on the application side ( i.e disableFrameRate together with enableVerticalSync )?
  • Does it stutter if you disable altogether vertical sync and the frame rate limiter?
  • Does it stutter if you disable the gl path? ( i.e force this option to false )

I don't see what else could be different in the fullscreen mode since the decoding and texture generation from the GStreamer side depends on the resolution/frame rate of the video and this stays the same no matter if running on windowed or fullscreen mode thus my thinking regarding a vsync issue.

Other than that this should be, in principle, ready from my side.

@richardeakin
Copy link
Collaborator

Do you mean that once you switch to fullscreen there is from then on continuous heavy stuttering during playback which disappears if you switch back to window mode?

Hm, this is exactly what was happening when I tested, although I just tried again and can't reproduce. All videos are playing well, from 720p on up to 4K via drag and drop. I'm going to merge and if we see it come up again, will make raise an issue to investigate then. Thanks Petros!

@richardeakin richardeakin merged commit 38032f6 into cinder:master Nov 3, 2018
@PetrosKataras PetrosKataras deleted the gstplayer-msw-support branch November 3, 2018 08:50
3togo pushed a commit to 3togo/Cinder that referenced this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants