-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all blocks and samples on linux, add cairo support #2134
Conversation
Really awesome that you took this on, thanks! It will be great to finally have all samples building in Linux, a big step in cross-platform equality. We're gearing up for a release within the very near future, so I think we'll try to get this work integrated within the next release cycle. I think we should probably simplify this PR to things related to cairo / svg samples as much as possible. I haven't yet had time to review or run this code, but I hope that we can soon. |
I wanted to try Cinder for an upcoming project. I'm a full time linux user, and couldn't help but notice that most samples wouldn't build on Ubuntu 18.04.
Hence, I reviewed each block and each sample to make sure they now build and work (except those that aren't supported on linux of course). I added the samples that aren't supported to the
CINDER_SKIP_SAMPLES
list.This also led me to add linux support for Cairo because I wanted to try the
_svg
samples. I've changed a few bits of code in the Cairo block, one should try to build it on windows and osx to make sure I didn't break anything. If you want a second PR just for that, I can rework my branch.This PR should close #1483 close #2052 close #2022 and maybe close #1815 (most Cairo samples also require
Renderer2D
which is still not implemented on linux).Any comments would be appreciated.