Fix IABEssenceClipWrappedElement key #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kblinova
reviewed
Aug 24, 2020
| @@ -179,7 +183,7 @@ AS_02::IAB::MXFWriter::OpenWrite( | |||
|
|
|||
| byte_t clip_buffer[RESERVED_KL_SIZE] = { 0 }; | |||
|
|
|||
| memcpy(clip_buffer, this->m_Writer->m_Dict->ul(MDD_IMF_IABEssenceClipWrappedElement), ASDCP::SMPTE_UL_LENGTH); | |||
| memcpy(clip_buffer, element_ul_bytes, ASDCP::SMPTE_UL_LENGTH); | |||
There was a problem hiding this comment.
Why not define MDD_IMF_IABEssenceClipWrappedElement to include 01 and 01 in places of 7f and 7f? This Essence UL is defined to be in the context of OP1 header. What flexibility does defining this UL as 7f and 7f add?
There was a problem hiding this comment.
What flexibility does defining this UL as 7f and 7f add?
The UL matches the SMPTE registers exactly.
There was a problem hiding this comment.
A couple of things:
- It would be good to have a way to set these bytes in ULs in a systematic way instead of using array subscripts; That makes is a supported library functionality
- There will be an issue comparing the UL found in the MXF files back with the MDD table definitions. This happens in as-02-info and klv-walk where the ULs are turned into printable strings for human consumption.
There was a problem hiding this comment.
Following this expedient pull request I would appreciate a contribution that better addresses the 7f placeholder issues. What constitutes "better" is not yet obvious to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59