Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading on older browsers #397

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Fix loading on older browsers #397

merged 1 commit into from
Mar 18, 2022

Conversation

nitanmarcel
Copy link
Contributor

@nitanmarcel nitanmarcel commented Mar 17, 2022

Description

Some browsers might not have updated to a newer version of javascript, thus being unable to use the web app. An example would be Morph browser on Ubuntu Touch or QtWebView 5.12 in general.

js: Uncaught (in promise) TypeError: n.replaceAll is not a function

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://6233ead2a284414bbcf8ef54--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ajbura ajbura merged commit a2655ee into cinnyapp:dev Mar 18, 2022
@kfiven kfiven added this to the v2.0.0 milestone Mar 18, 2022
@kfiven kfiven mentioned this pull request Mar 23, 2022
1 task
@ajbura ajbura mentioned this pull request Sep 13, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants