Allow rendering messages as plaintext #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginnyTheCat
force-pushed
the
markdown-emojis
branch
4 times, most recently
from
ab14056
to
4929c61
Compare
ginnyTheCat
force-pushed
the
markdown-emojis
branch
2 times, most recently
from
da0fd69
to
de98770
Compare
ginnyTheCat
force-pushed
the
markdown-emojis
branch
from
cd3f638
to
e939176
Compare
ajbura
reviewed
Sep 12, 2022
ajbura
reviewed
Sep 13, 2022
Comment on lines
+208
to
+212
| shrug: { | ||
| order: defaultRules.escape.order - 0.1, | ||
| match: inlineRegex(/^¯\\_\(ツ\)_\/¯/), | ||
| parse: (capture) => ({ type: 'text', content: capture[0] }), | ||
| }, |
There was a problem hiding this comment.
Wondering why we have a shrug rule?
There was a problem hiding this comment.
this allows the shrug to no loose his left arm due to it parsing it as markdown (the first \ disappearing as it escapes the _ after it). now smb can just paste in a shrug in or use the /shrug command without having to worry about markdown behaving weirdly.
Comment on lines
+123
to
+126
| fence: { | ||
| ...defaultRules.fence, | ||
| match: blockRegex(/^ *(`{3,}|~{3,}) *(?:(\S+) *)?\n([\s\S]+?)\n?\1 *(?:\n *)*\n/), | ||
| }, |
There was a problem hiding this comment.
this is a code fence which is a codeblock surrounded by ```. this gets converted into a codeBlock after parsing.
ginnyTheCat
force-pushed
the
markdown-emojis
branch
from
25b3df9
to
3069f0d
Compare
ajbura
approved these changes
Sep 14, 2022
NovaAndrom3da
pushed a commit
to NovaAndrom3da/neocinny
that referenced
this pull request
Nov 23, 2023
* Parse room input from user id and emoji * Add more plain outputs * Add reply support * Always include formatted reply * Add room mention parser * Allow single linebreak after codeblock * Remove margin from math display blocks * Escape shrug * Rewrite HTML tag function * Normalize def keys * Fix embedding replies into replies * Don't add margin to file name * Collapse spaces in HTML message body * Don't crash with no plaintext rendering * Add blockquote support * Remove ref support * Fix image html rendering * Remove debug output * Remove duplicate default option value * Add table plain rendering support * Correctly handle paragraph padding when mixed with block content * Simplify links if possible * Make blockquote plain rendering better * Don't error when emojis are matching but not found * Allow plain only messages with newlines * Set user id as user mention fallback * Fix mixed up variable name * Replace replaceAll with replace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the way sending messages (with edits and replies) is handled in
RoomsInput.jsand adds plaintext rendering of messages (plain and markdown). This allows for hiding spoilers in plain messages in the future. For now this moves mention and emoji to be parsing over tosimple-markdown.Fixes #770
Fixes #746
Type of change
Checklist:
Preview: https://805--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️