-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Markdown parsing #719
Conversation
a5f4066
to
b06399c
Compare
Is it ready for review? |
i think it's ready. |
bfae696
to
a0312eb
Compare
Sorry for messing up the commits a bit. Accidentally did a rebase which clashed with your merge. Hope it's ok now |
|
||
& p:not(:last-child) { | ||
margin-bottom: var(--sp-normal); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace \n with <br />
instead of applying client specific css for newlines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to space <p>
tags further apart to make them appear as actual paragraphs (as shown in the screenshots of #193). this does not relate to \n
or <br>
afaik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you :).
* Switch markdown parser * Add inline maths * Basic plain text rendering * Add display math support * Remove unnecessary <p> tag * Fixed spoiler not working * Add spoiler reason input support * Make paragraphs display with newline in between * Handle single newlines * Fix typo when allowing start attribute * Cleanup for merge * Remove unused import
Description
Simplify markdown parsing to allow for new features and better spec compliance.
||spoiler||
syntax||spoiler||(reason)
syntax$1+1
$$1+1$$
$$1+1$$
(new)$$\n1+1\n$$
Fixes #709
Fixes #193
Fixes #749 (replicate element behavior)
Type of change
Checklist:
Preview: https://6302170673d245070a1fa41c--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️