Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container images #26

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Container images #26

merged 4 commits into from
Feb 13, 2023

Conversation

byo
Copy link
Contributor

@byo byo commented Feb 13, 2023

No description provided.

* Remove the server command - it's not a functionality that should
  be given by static_datastore command line anymore since there's
  the web_proxy one
* Use json for output - especially for the entrypoint data,
  no longer entrypoint information
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 77.08% // Head: 78.62% // Increases project coverage by +1.54% 🎉

Coverage data is based on head (5aab984) compared to base (39c6487).
Patch coverage: 10.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   77.08%   78.62%   +1.54%     
==========================================
  Files          28       27       -1     
  Lines        1798     1689     -109     
==========================================
- Hits         1386     1328      -58     
+ Misses        355      316      -39     
+ Partials       57       45      -12     
Impacted Files Coverage Δ
pkg/cmd/static_datastore/root.go 0.00% <ø> (ø)
pkg/cmd/static_datastore/compile.go 12.96% <4.25%> (-9.02%) ⬇️
pkg/cmd/cinode_web_proxy/root.go 74.35% <100.00%> (+2.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@byo byo merged commit 4bf4059 into master Feb 13, 2023
@byo byo deleted the container-images branch February 13, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant