Add upload token configuration #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such upload token is a trivial protection against unauthorized upload of data. Even if such data would pass the validation, huge amounts of data can be generated in order to perform a DoS attack by abusing storage requirements of the node.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 88.18% 88.59% +0.40%
==========================================
Files 29 29
Lines 1837 1903 +66
==========================================
+ Hits 1620 1686 +66
Misses 181 181
Partials 36 36
☔ View full report in Codecov by Sentry. |
That way it's easier to encode credentials in a standard URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such upload token is a trivial protection against
unauthorized upload of data. Even if such data would pass the validation, huge amounts of data can be generated in order to perform a DoS attack by abusing storage requirements of the node.