Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalajs / sconfig Support #191

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

arashi01
Copy link

  • Adds support for sconfig library as alternative to Typesafe Config
  • Adds support for Scala.js (using sconfig library)

@arashi01 arashi01 marked this pull request as ready for review January 24, 2021 12:46
@arashi01
Copy link
Author

@jonas, @travisbrown Any chance you can have a quick look and let me know your thoughts?

Would be great to have Scala.js support!

Copy link
Member

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The idea sounds reasonable to me, although it's @jonas's decision to make. I also haven't looked at the generation code in detail.

src/main/scala/io.circe.config/package.scala Outdated Show resolved Hide resolved
@arashi01
Copy link
Author

Thanks for the PR! The idea sounds reasonable to me, although it's @jonas's decision to make. I also haven't looked at the generation code in detail.

Okay great!

The converters in Predef can be used when called explicitly. Will wait on additional feedback before making the change. Should be a quick fix.

@arashi01
Copy link
Author

@jonas any chance you can have a look at this?

@evbo
Copy link

evbo commented Jul 5, 2021

Hi @travisbrown @jonas , is this going to be merged into master and if not what is the recommended way to use HOCON files in scalajs?

I currently use circe for all scalajs json serde and am migrating to hocon for smaller footprint. What are my options until this is supported here?

@travisbrown
Copy link
Member

I'm only doing maintenance on this project (merging Scala Steward PRs, publishing releases, etc.), and I've had enough trouble with Scala.js support in other projects that I don't personally want to sign up to maintain it here (or to volunteer @jonas to do that).

I do appreciate that you've put in this effort, and if you'd be willing to volunteer to join the project as a maintainer (or know someone who would), and if @jonas agrees, that might be a way forward.

@arashi01
Copy link
Author

arashi01 commented Jul 6, 2021

@travisbrown I am happy to clean this up if needed in any way to get it merged.

Also happy to volunteer as a maintainer if needed in order to support Scala JS and Scala Native.

@arashi01
Copy link
Author

arashi01 commented Nov 7, 2021

@jonas Any chance of your input on this?

As mentioned before, if you're willing, I'm happy to make any changes necessary to get this merged.

Also happy to volunteer as an additional maintainer if necessary to handle standard housekeeping/maintenance issues.

cc @travisbrown

@travisbrown
Copy link
Member

I'll plan to merge and publish this if nobody speaks up by this Tuesday (the 9th).

@arashi01
Copy link
Author

arashi01 commented Nov 8, 2021

Okay great. Just rebased on top of current mainline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants