Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Codec.codecForEnumeration, add tests, change error slightly #1232

Merged
merged 4 commits into from
Aug 21, 2019

Conversation

travisbrown
Copy link
Member

I've added laws-checking for these instances, which turned up the fact that on decoding failures we were passing along the whole NoSuchElementException stack trace, which seems kind of bad, so I fixed it.

@codecov-io
Copy link

codecov-io commented Aug 21, 2019

Codecov Report

Merging #1232 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1232     +/-   ##
=========================================
- Coverage   86.55%   86.46%   -0.1%     
=========================================
  Files          92       92             
  Lines        2841     2859     +18     
  Branches      123      119      -4     
=========================================
+ Hits         2459     2472     +13     
- Misses        382      387      +5
Impacted Files Coverage Δ
...es/core/shared/src/main/scala/io/circe/Codec.scala 64% <100%> (+64%) ⬆️
.../core/shared/src/main/scala/io/circe/Decoder.scala 85.32% <100%> (-0.18%) ⬇️
.../core/shared/src/main/scala/io/circe/Encoder.scala 89.28% <100%> (ø) ⬆️
...les/core/shared/src/main/scala/io/circe/Json.scala 78.04% <0%> (-1.83%) ⬇️
...re/shared/src/main/scala/io/circe/JsonNumber.scala 96.38% <0%> (-1.21%) ⬇️
...rc/main/scala/io/circe/numbers/BiggerDecimal.scala 84.21% <0%> (-0.59%) ⬇️
...re/shared/src/main/scala/io/circe/KeyDecoder.scala 97.29% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e1f86...ed26066. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants