Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different language for approved list of JSON keys. #1478

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

kevinmeredith
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #1478 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
- Coverage   85.94%   85.76%   -0.19%     
==========================================
  Files          57       57              
  Lines        2184     2184              
  Branches      109      109              
==========================================
- Hits         1877     1873       -4     
- Misses        307      311       +4     
Impacted Files Coverage Δ
...re/shared/src/main/scala/io/circe/JsonNumber.scala 92.77% <0.00%> (-4.82%) ⬇️
...rc/main/scala/io/circe/numbers/BiggerDecimal.scala 85.38% <0.00%> (-1.17%) ⬇️
.../core/shared/src/main/scala/io/circe/Decoder.scala 85.28% <0.00%> (+0.27%) ⬆️
...les/core/shared/src/main/scala/io/circe/Json.scala 80.44% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a00a7...f15cf2d. Read the comment docs.

@travisbrown
Copy link
Member

👍, thank you for doing this, @kevinmeredith.

@travisbrown travisbrown merged commit 3ff4dc8 into circe:master Jun 8, 2020
@kevinmeredith kevinmeredith deleted the change-language branch June 8, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants