Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to (_cc1/environment-variables.md) from both 12.04 and 14.04 & remove env vars from 12.04 #158

Closed
brycefisher opened this issue May 26, 2016 · 8 comments

Comments

@brycefisher
Copy link

Currently there are three environment documentation pages:

However, only the Ubuntu 12.04 lists the environment variables available during a build inside the container. So, its unclear to me whether the environment variables are the same regardless of environment, or if there are differences in which environment variables exposed. (Let's ignore build parameters from the build API, since I'm only discussing CircleCI provided environment variables.)

Here's my proposal:

  • If the environments are the same in Ubuntu 12.04 and 14.04, then move the environment variables to the landing page and off the ubuntu 12.04 page
  • If there are differences between the two build environments, list all of the CircleCI provided environment variables on each page.
@brycefisher brycefisher changed the title RE: jekyll/_docs/build-image-trusty.md CircleCI Environment Variables -- jekyll/_docs/build-image-trusty.md May 26, 2016
@FelicianoTech
Copy link
Contributor

Hi @brycefisher, thank you so much for pointing this out. I've looked at those pages several times recently and somehow didn't notice that. I'm leaning towards your first suggestion. That makes a lot of sense.

@brycefisher
Copy link
Author

Awesome thanks!

@FelicianoTech FelicianoTech added this to the Phase 2 milestone Sep 28, 2016
@FelicianoTech FelicianoTech removed this from the Phase 2 milestone Jan 5, 2017
@keybits
Copy link
Contributor

keybits commented Feb 23, 2017

This appears to be fixed: https://circleci.com/docs/1.0/environment/

@FelicianoTech can we close?

@smart-alek
Copy link
Contributor

smart-alek commented Mar 2, 2017

@keybits that link just goes to separate 12.04 and 14.04 pages. But I think this article is what @brycefisher was looking for. Let me know if that's not sufficient, and we'll re-open this!

@brycefisher
Copy link
Author

@smart-alek yes! That article is definitely the content I was looking for. IMHO, it would make sense to remove the environment vars from the 12.04 page and add a link to https://circleci.com/docs/1.0/environment-variables/ from both image pages.

@smart-alek
Copy link
Contributor

Great suggestion, @brycefisher! I'll reopen and rename this one to incorporate that.

@smart-alek smart-alek reopened this Mar 3, 2017
@smart-alek smart-alek changed the title CircleCI Environment Variables -- jekyll/_docs/build-image-trusty.md Add link to environment variables page from both 12.04 and 14.04 (_cc1/environment-variables.md) Mar 3, 2017
@smart-alek smart-alek changed the title Add link to environment variables page from both 12.04 and 14.04 (_cc1/environment-variables.md) Add link to (_cc1/environment-variables.md) from both 12.04 and 14.04 & remove env vars from 12.04 Mar 3, 2017
@smart-alek
Copy link
Contributor

@brycefisher thanks for your help on this! We're closing out most of our 1.0 issues involving edits in favor of focusing on 2.0 docs. Just didn't want you to wonder what happened to this, though. :)

@brycefisher
Copy link
Author

No worries at all! Thanks for looping me in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants