Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing username - password auth step works #1782

Closed
hyprstack opened this issue Nov 22, 2017 · 2 comments
Closed

Removing username - password auth step works #1782

hyprstack opened this issue Nov 22, 2017 · 2 comments
Assignees
Labels
incorrect incorrect information unclear confusing language

Comments

@hyprstack
Copy link

This issue is about https://circleci.com/docs/2.0/google-container-engine/ (source file: https://github.com/circleci/circleci-docs/blob/master/jekyll/_cci2/google-container-engine.md)

When trying to upload a cloud function using this guide, although I had a service account json key with the appropriate permissions to upload a cloud function, the step where

    auth:
    #Put the contents of keyfile.json into an environment variable for the build called GCR_CREDS, which is then passed in.
      username: _json_key
      password: $GOOGLE_AUTH 

failed constantly in circle ci with the error message

Build-agent version 0.0.4545-ba6be34 (2017-11-20T20:01:46+0000)
Downloading previous test results
Starting container google/cloud-sdk:latest
  image is cached as google/cloud-sdk:latest, but refreshing...
Error response from daemon: Get https://registry-1.docker.io/v2/google/cloud-sdk/manifests/latest: unauthorized: incorrect username or password

I found that removing auth: ... completely from the config file solved my problem.

Also explaining whether the comment #Put the contents of keyfile.json into an environment variable for the build called GCR_CREDS, which is then passed in. is relevant would be good too.

Perhaps an explanation to what _json_key as username does would be helpful too as I also spent a lot of time replacing it, to no avail, in the hopes of getting the docs to work.

@smart-alek smart-alek assigned smart-alek and unassigned smart-alek Jan 18, 2018
@smart-alek smart-alek added unclear confusing language Type: Inaccuracy labels Jan 24, 2018
@smart-alek smart-alek self-assigned this Feb 2, 2018
@smart-alek smart-alek added incorrect incorrect information and removed Topic: Google Cloud labels Feb 14, 2018
@circleci circleci deleted a comment Feb 14, 2018
@smart-alek
Copy link
Contributor

@hyprstack! Hello!!

I believe that a recent PR has addressed the issues you've raised here: go check out #2142, or just read the updated document itself. If you find any outstanding issues, I'll be happy to re-open this!

@hyprstack
Copy link
Author

@smart-alek looks good! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incorrect incorrect information unclear confusing language
Projects
None yet
Development

No branches or pull requests

2 participants