Google Container Engine clarifications #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment variables should not be prefixed with dollar signs unless they are used explicitly in a bash command.
Clarify why we're using "_json_key" as the username. Properly indent steps within a deploy job.
GERey
reviewed
Mar 13, 2018
| gcloud --quiet config set project ${GOOGLE_PROJECT_ID} | ||
| gcloud --quiet config set compute/zone ${GOOGLE_COMPUTE_ZONE} | ||
| gcloud --quiet container clusters get-credentials ${GOOGLE_CLUSTER_NAME} | ||
| ``` | ||
|
|
||
|
|
||
| Refer to the [Google Cloud](https://circleci.com/docs/2.0/deployment-integrations/#google-cloud) deploy example for further steps. |
There was a problem hiding this comment.
Feels weird to link people to the rest of deploy section, when the page itself is called "deploying to", but its what the deployment-integrations page is for so w/e
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2134 and fixes #1670.
While working on this document, I realized a couple of things:
There is a lot of overlapping information between this document and the Authenticating Google Cloud document.
Both documents are mostly focused on steps preceding the actual deploy (authentication, environment variables, etc.).
The actual deploy instructions seem to be on the deploy landing page, but these seem to be a bit lean.
At the very least, we should consolidate Authenticating Google Cloud Platform and Deploying to Google Container Engine.
If we're feeling ambitious, I would pull all relevant Google Cloud setup documentation into a single document that is linked to from the Deploy landing page. The other deploy platforms could benefit from their own spaces as well.