Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve descriptions of some environment variables #4401

Merged
merged 2 commits into from Jun 2, 2020

Conversation

marcomorain
Copy link
Contributor

  • Move deprecated and internal variables to the bottom of the list.
  • Bring CIRCLECI to the top of the list.
  • Make clear that CIRCLE_INTERNAL_TASK_DATA is internal.
  • Improve the accuracy of other descriptions.

- Move deprecated and internal variables to the bottom of the list.
- Bring `CIRCLECI` to the top of the list.
- Make clear that `CIRCLE_INTERNAL_TASK_DATA` is internal.
- Improve the accuracy of other descriptions.
@sulami
Copy link
Contributor

sulami commented May 22, 2020 via email

@@ -517,8 +514,11 @@ Variable | Type | Value
`CIRCLE_USERNAME` | String | The GitHub or Bitbucket username of the user who committed the build.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed the build probably needs changing...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"whose commit triggered the pipeline" perhaps?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For webhooks it's the pusher rather than committer, for API calls it's the API caller. So maybe "the user who triggered the pipeline"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's what I was thinking... hopefully Server people won't be confused by pipeline

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, so this isn't the same user that's attributed for credit usage?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you say the user who triggered the pipeline, does that’s mean for pipelines triggered by API it will be the user whose token I am using?

also if i do "rerun" or "rerun from failed" on a build started by userA does the CIRCLE_USERNAME change to the person who re-ran?

@rosieyohannan rosieyohannan merged commit 1cef1ea into master Jun 2, 2020
@rosieyohannan rosieyohannan deleted the marcomorain-patch-2 branch June 2, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants