[CIRCLE-37398] Fix for CVE-2020-8165 (activesupport) #5636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsylvian
changed the title
nramabad
force-pushed
the
snyk-fix-3cc5be386c8af04cea84f9618b761c27
branch
from
c71ff04
to
2723aa5
Compare
nramabad
reviewed
Aug 25, 2021
nramabad
reviewed
Aug 25, 2021
| gem 'middleman-sprockets', '~> 4.1.0' | ||
| gem 'rouge', '~> 2.0.5' | ||
| gem 'redcarpet', '~> 3.4.0' | ||
| gem 'nokogiri', '~> 1.10.8' | ||
| gem "therubyracer" |
There was a problem hiding this comment.
this is unnecessary nowadays and adds a large memory footprint not to mention source of build failure
…ry therubyracer & comment out sprockets The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-ACTIVESUPPORT-569598
nramabad
force-pushed
the
snyk-fix-3cc5be386c8af04cea84f9618b761c27
branch
from
2723aa5
to
ebe1a51
Compare
rsylvian
approved these changes
Aug 26, 2021
@teesloane you got any ideas? |
|
We should clone this locally test it, and then rename the branch to a |
|
The output artifact of v1 (src-api) can be viewed here. |
teesloane
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix one or more vulnerable packages in the `rubygems` dependencies of this project.
Changes included in this PR
Vulnerabilities that will be fixed
With an upgrade:
Why? Mature exploit, Has a fix available, CVSS 8.1
SNYK-RUBY-ACTIVESUPPORT-569598
(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic