-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websockets and externalization of histogram code into libcircllhist #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests for websockets
This looks good to me. |
Tested a build from this branch and found that a couple additional binaries are linking libcircllhist, in addition to the expected histogram.so module:
Neither of these are show-stoppers; they are simply unexpected (at least by me). The postgres module is the more perplexing. |
I get this error building on EL6:
|
Builds correctly on Circonus-supported platforms. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires
--enable-wslay
support in libmtev. And it requires a package forlibcircllhist
(https://github.com/circonus-labs/libcircllhist).This allows you to connect a websocket to
http(s)://<broker>/livestream
and send down a request for data like:And you will get back individual livestreamed metrics at
period_ms
which are filtered to the names inmetrics
. You can get all metrics under that check by omitting themetrics
field from the request.