Include rtt no matter if there is an error or not. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| noit_stats_set_metric(ci->check, &ci->current, "rtt", METRIC_DOUBLE, | ||
| ci->timed_out ? NULL : &rtt); | ||
|
|
There was a problem hiding this comment.
Does this set rtt in the case of a timeout? I agree we should be setting rtt regardless of the response, but not if there is not response.
There was a problem hiding this comment.
does set_metric as NULL not actually set the metric? I figured that's what it did.
There was a problem hiding this comment.
setting the metric as null sets the metric and sets it to null. If you don't want the metric to come back at all, you skip the set.
if(!ci->timed_out) noit_stats_set_metric(...)
There was a problem hiding this comment.
But as this doesn't appear to change the behaviour on timeouts.. I suppose it is okay as is.
postwait
added a commit
that referenced
this pull request
Jun 8, 2012
Include rtt no matter if there is an error or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.