Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab key functionality and add hotkeys #119

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

makermelissa
Copy link
Collaborator

Fixes #117. Fixes #116.

Comment on lines +344 to +347
{ key: "Mod-s", run: saveFile },
{ key: "Mod-o", run: openFile },
{ key: "Alt-n", run: newFile },
{ key: "Mod-r", run: saveRunFile },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you want to do Ctrl instead of Mod on windows? Or does CodeMirror handle it?

Copy link
Collaborator Author

@makermelissa makermelissa Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codemirror handles it. Mod means it uses Cmd on a mac and Ctrl on a PC.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question. Up to you if you want to merge as-is.

@makermelissa makermelissa merged commit 8ad3832 into circuitpython:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hotkeys for buttons Pressing Tab key should add 4 spaces
2 participants