Improve handlers channels gathering

[apollo13]

According to:

circuits/circuits/core/manager.py

Lines 335 to 337 in 70080ac

	# XXX: Why do we care about the event handler's channel?
	# This probably costs us performance for what?
	# I've not ever had to rely on this in practice...

the handler_channel always falls back to the component channel which kinda makes sense to "scope" them by default.

What about instead of doing that while getting the handlers, do that on handler registration:

circuits/circuits/core/handlers.py

Lines 118 to 126 in 70080ac

	class HandlerMetaClass(type):
	def __init__(cls, name, bases, ns):
	super(HandlerMetaClass, cls).__init__(name, bases, ns)
	callables = (x for x in ns.items() if isinstance(x[1], Callable))
	for name, callable in callables:
	if not (name.startswith("_") or hasattr(callable, "handler")):
	setattr(cls, name, handler(name)(callable))

We do have access to the whole class namespace there…

EDIT:// We'd still need to take care of that in the handler decorator itself since users can manually apply it without a channel name…
EDIT2:// Actually it isn't so simple, this probably doesn't take subclasses etc into account which can change the channel name XD

[prologic]

Yeah I'm not sure why we do it this way either :/ Let's try? James Mills / prologic E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au

…

On Sun, Jan 22, 2017 at 10:23 PM, Florian Apolloner < ***@***.***> wrote: According to: https://github.com/circuits/circuits/blob/70080ac77dce53921521b7a743a56c 68bdea0911/circuits/core/manager.py#L335-L337 the handler_channel always falls back to the component channel which kinda makes sense to "scope" them by default. What about instead of doing that while getting the handlers, do that on handler registration: https://github.com/circuits/circuits/blob/70080ac77dce53921521b7a743a56c 68bdea0911/circuits/core/handlers.py#L118-L126 We do have access to the whole class namespace there… — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#210>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOv-jMyMsfxXkp6KqESmna9re6CQeH3ks5rU9b0gaJpZM4Lqhug> .