Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "auto_add" parameter to circuits.io.notify.add_path() #239

Closed
kromg opened this issue May 31, 2018 · 2 comments
Closed

Adding "auto_add" parameter to circuits.io.notify.add_path() #239

kromg opened this issue May 31, 2018 · 2 comments
Assignees

Comments

@kromg
Copy link
Collaborator

kromg commented May 31, 2018

Greetings!
As mentioned on IRC, I'd like to add a parameter: auto_add with default: True to circuits.io.notify.add_path().

The reason is that I noticed that trying to add subpaths manually when they're created can cause event loss. Passing auto_add=True to pyintoify seems to solve this problem.

If you're ok with this, I can submit a PR.

@kromg kromg self-assigned this Jun 12, 2018
kromg added a commit to kromg/circuits that referenced this issue Jun 12, 2018
* Added auto_add with default to True to notify.add_path().
  Fixes circuits#239.
kromg added a commit to kromg/circuits that referenced this issue Jun 12, 2018
prologic pushed a commit that referenced this issue Jun 13, 2018
* Added auto_add to notify.add_path()

* Added auto_add with default to True to notify.add_path().
  Fixes #239.

* Added various notify tests (#239)
@spaceone
Copy link
Contributor

There are syntax errors introduced by this PR for python2. Could you have a look again. E.g:
https://travis-ci.org/circuits/circuits/jobs/427305635

E     File "/home/travis/build/circuits/circuits/tests/io/test_notify.py", line 31
E       def create(self, *targets, assert_created=True, dir=False):
E                                               ^
E   SyntaxError: invalid syntax

@spaceone
Copy link
Contributor

I fixed those syntax errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants