-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding "auto_add" parameter to circuits.io.notify.add_path() #239
Comments
kromg
added a commit
to kromg/circuits
that referenced
this issue
Jun 12, 2018
* Added auto_add with default to True to notify.add_path(). Fixes circuits#239.
kromg
added a commit
to kromg/circuits
that referenced
this issue
Jun 12, 2018
Merged
prologic
pushed a commit
that referenced
this issue
Jun 13, 2018
There are syntax errors introduced by this PR for python2. Could you have a look again. E.g:
|
spaceone
added a commit
that referenced
this issue
Sep 12, 2018
prologic
pushed a commit
that referenced
this issue
Sep 12, 2018
I fixed those syntax errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Greetings!
As mentioned on IRC, I'd like to add a parameter:
auto_add
with default:True
tocircuits.io.notify.add_path()
.The reason is that I noticed that trying to add subpaths manually when they're created can cause event loss. Passing
auto_add=True
to pyintoify seems to solve this problem.If you're ok with this, I can submit a PR.
The text was updated successfully, but these errors were encountered: