-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for handling request without headers #238
Conversation
kwangswei
commented
Apr 18, 2018
- Circuits couldn't receive a request which doesn't have any headers
- None of the HTTP headers are required in a HTTP/1.0 request.
- For example, "GET / HTTP/1.0\r\n\r\n"
- This commit fixed this issue
Can you confirm there was no regression in the test suite with this diff? |
Ooops... I'm sorry. |
I approve the change obviously; but just want to be sure there are no regressions! Thanks also for adding a new test case to cover this. |
- None of the HTTP headers are required in a HTTP/1.0 request. - Circuits couldn't receive a request which doesn't have any headers - For example, "GET / HTTP/1.0\r\n\r\n" - This commit fixed this issue
@prologic Could you check the result of CI build? It failed with test_tcp and test_udp and I don't think my code caused that error. |
This change had a regression, it requires chunked Transfer encoding to provide any trailer header otherwise:
|