Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for handling request without headers #238

Merged
merged 1 commit into from Apr 19, 2018
Merged

Conversation

@kwangswei
Copy link
Contributor

kwangswei commented Apr 18, 2018

  • Circuits couldn't receive a request which doesn't have any headers
  • None of the HTTP headers are required in a HTTP/1.0 request.
  • For example, "GET / HTTP/1.0\r\n\r\n"
  • This commit fixed this issue
@prologic
Copy link
Member

prologic commented Apr 18, 2018

Can you confirm there was no regression in the test suite with this diff?

@kwangswei
Copy link
Contributor Author

kwangswei commented Apr 19, 2018

Ooops... I'm sorry.
I will check it again.

@prologic
Copy link
Member

prologic commented Apr 19, 2018

I approve the change obviously; but just want to be sure there are no regressions!

Thanks also for adding a new test case to cover this.

jesse.ha
- None of the HTTP headers are required in a HTTP/1.0 request.
- Circuits couldn't receive a request which doesn't have any headers
- For example, "GET / HTTP/1.0\r\n\r\n"
- This commit fixed this issue
@kwangswei kwangswei force-pushed the kwangswei:master branch from 1f4b7c5 to 791d436 Apr 19, 2018
@kwangswei
Copy link
Contributor Author

kwangswei commented Apr 19, 2018

@prologic Could you check the result of CI build? It failed with test_tcp and test_udp and I don't think my code caused that error.

@prologic prologic merged commit ecfbe00 into circuits:master Apr 19, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.