implements the stderr/stdout stream redirection #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # if gevent and gevent_zmq are available, let's use a Greenlet | ||
| # o/wise fallback to a Thread + a select | ||
| try: |
There was a problem hiding this comment.
maybe having in the ini the setting
[circus]
backend = gevent
instead of testing on import would be better ? or do you think it can wait next release?
There was a problem hiding this comment.
Why not, but 'backend' is a bit vague at this level.
If the idea is to say = we will use gevent here and there in Circus when it's useful to speed up and/or scale a feature, I propose to rename it to "use_gevent = 1"
There was a problem hiding this comment.
mmm the idea is more: if we don't find gevent when you want is as the backend we raise, else we use thread.
use_gevent would mean for me that we fallback on thread if gevent is not installed. Both are OK for me, it would be interesting to have opinions of an OP or admin there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch implements the stderr/stdout stream redirection