Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mac CBZ, CBR, cover upload, damaged #566

Merged
merged 2 commits into from Aug 6, 2023
Merged

Conversation

axu2
Copy link
Collaborator

@axu2 axu2 commented Jul 31, 2023

Fix Mac CBZ, CBR, damaged, cover upload, when frozen

Frozen is referring to a binary frozen by PyInstaller.

Copying files into the PyInstaller .app appears to cause a whole lot of issues. Don't see a reason to not use homebrew 7z and the PyInstaller default plist. Plus homebrew stuff like 7z/unar is in a different location on M1.

Also removed the PATH words since that's not needed anymore.

Thank you to @maxthiel at #528 (comment) for testing

Thank you to @killam42 : #569 (comment) for testing

Beta Mac dmg for testing: https://github.com/axu2/kcc/actions/runs/5709825357
Updated dmg: https://github.com/axu2/kcc/actions/runs/5746658564

Also will open errors in separate window, like if you didn't brew install unar. Using separate window since unpacking errors can be LONG:

image

7z doesn't support rar on Mac.
unrar doesn't exist on Mac.

unar does. Just brew install unar

In the meantime use a separate app like unarchiver to extract the files first before putting them into kcc. May be better option for linux and fedora.

@Evidlo @cookie99999 @AlicesReflexion @aliafshany @jthulhu @celogeek

@axu2 axu2 changed the title Fix Mac damaged, cover upload, 7z errors Fix Mac damaged, cover upload, 7z errors when frozen Jul 31, 2023
@axu2 axu2 marked this pull request as ready for review July 31, 2023 02:11
@axu2 axu2 changed the title Fix Mac damaged, cover upload, 7z errors when frozen Fix Mac damaged, cover upload, 7z when frozen Jul 31, 2023
@axu2 axu2 changed the title Fix Mac damaged, cover upload, 7z when frozen Fix Mac damaged, cover upload, CBZ, CBR when frozen Aug 3, 2023
@axu2
Copy link
Collaborator Author

axu2 commented Aug 3, 2023

@maxthiel @killam42 feel free to test the CBR build here and report if it works: https://github.com/axu2/kcc/actions/runs/5746658564

@jthulhu
Copy link

jthulhu commented Aug 4, 2023

I'm not sure on why I was pinged, I am not a maintainer of this repo.

@maxthiel
Copy link

maxthiel commented Aug 4, 2023

Hi @axu2 ,

I'm getting this error with the build above:
image

Which is promptly solved by a brew install unar.
I had The Unarchiver app installed so I assumed the cli was there as well, turns out I was wrong.

@axu2
Copy link
Collaborator Author

axu2 commented Aug 4, 2023

@maxthiel Was that cbr or rar?
@jthulhu you had a cbr issue on POSIX in #358 and thought you might be interested

@jthulhu
Copy link

jthulhu commented Aug 4, 2023

@axu2 ok, I appreciate the intention :) I didn't remember that issue, it was too much time ago. Btw, the issue was under Linux, if that can help.

@maxthiel
Copy link

maxthiel commented Aug 4, 2023

Was that cbr or rar?

Looks like I've blurred to much!
Yes it was a cbr.

@axu2 axu2 changed the title Fix Mac damaged, cover upload, CBZ, CBR when frozen Fix Mac CBZ, CBR, damaged, cover upload, when frozen Aug 5, 2023
@darodi darodi added the macOS label Aug 5, 2023
@axu2
Copy link
Collaborator Author

axu2 commented Aug 6, 2023

Thanks to @borako for testing.
#436 (comment)

@axu2 axu2 changed the title Fix Mac CBZ, CBR, damaged, cover upload, when frozen Fix Mac support Aug 6, 2023
@axu2
Copy link
Collaborator Author

axu2 commented Aug 6, 2023

@darodi could we get a bugfix release out with this? Mac support requests are getting too frequent, since our currently provided dmg is pretty broken. Numerous Mac users have already tested this build.

@axu2 axu2 changed the title Fix Mac support Fix Mac CBZ, CBR, damaged, cover upload Aug 6, 2023
.decode("utf-8")

edit kindlegen text

adjust 7z text

add unar

delete spec

remove 7z binaries

change path priorities

add 7z location for m1

delete plist

fix mac cover upload
@darodi darodi merged commit cc1e5db into ciromattia:master Aug 6, 2023
@axu2 axu2 deleted the mac branch August 6, 2023 19:48
@axu2 axu2 changed the title Fix Mac CBZ, CBR, damaged, cover upload Fix Mac CBZ, CBR, cover upload Aug 6, 2023
@darodi darodi added this to the 5.6.3 milestone Aug 8, 2023
@axu2 axu2 changed the title Fix Mac CBZ, CBR, cover upload Fix Mac CBZ, CBR, cover upload, damaged Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment