Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to strict compilation mode for Typescript #502

Open
fkorotkov opened this issue Jan 14, 2023 · 1 comment
Open

Switch to strict compilation mode for Typescript #502

fkorotkov opened this issue Jan 14, 2023 · 1 comment
Assignees
@ikatemart

Comments

@fkorotkov
Copy link
Contributor

To prevent things like #500 and #501 we should flip strict config and fix all remaining types.
@fkorotkov
Copy link
Contributor Author

We can try with only strictNullChecks if strict is too noisy.

This was referenced Jan 14, 2023
Closed
Closed
@cirruslabs cirruslabs deleted a comment from RDIL Jan 15, 2023
fkorotkov added a commit that referenced this issue Jan 23, 2023
@fkorotkov
Switch to using makeStyles
813f727 
For #502 we need to upgrade react and relay. To upgrade react we need to upgrade MUI. This change moves current style usage to use `makeStyle` which we'll be able easily upgrade with [this codemod](https://mui.com/material-ui/migration/migrating-from-jss/#2-use-tss-react).
@fkorotkov fkorotkov mentioned this issue Jan 23, 2023
Merged
fkorotkov added a commit that referenced this issue Jan 24, 2023
@fkorotkov
Switch to using makeStyles (#507)
b6eb5c3 
* Switch to using makeStyles

For #502 we need to upgrade react and relay. To upgrade react we need to upgrade MUI. This change moves current style usage to use `makeStyle` which we'll be able easily upgrade with [this codemod](https://mui.com/material-ui/migration/migrating-from-jss/#2-use-tss-react).

* Prettier

* Updated snapshots
@fkorotkov fkorotkov mentioned this issue Jan 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikatemart ikatemart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fkorotkov @ikatemart