Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set HTTP client timeout to 30 seconds #153

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Set HTTP client timeout to 30 seconds #153

merged 2 commits into from
Feb 5, 2024

Conversation

edigaryev
Copy link
Collaborator

@edigaryev edigaryev commented Feb 5, 2024 •
edited
Loading

There's no timeout by default, which may result Orchard CLI or Worker hanging waiting for request to complete.

See #152.

@fkorotkov
Copy link
Contributor

Could you please be a bit more descriptive about why it fixed the mentioned issue?

@edigaryev edigaryev mentioned this pull request Feb 5, 2024
Closed
@edigaryev
Copy link
Collaborator Author

Could you please be a bit more descriptive about why it fixed the mentioned issue?

See #152 (comment).

@fkorotkov
Copy link
Contributor

Cool. Let's still have some description with a reference to the comment with the investigation.

@edigaryev
Copy link
Collaborator Author

Cool. Let's still have some description with a reference to the comment with the investigation.

See fc4d4a9.

@fkorotkov
Copy link
Contributor

Thank you!

@edigaryev edigaryev merged commit 2c5b038 into main Feb 5, 2024
3 checks passed
@edigaryev edigaryev deleted the http-client-timeout branch February 5, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkorotkov fkorotkov fkorotkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edigaryev @fkorotkov