Configure workers to log to a file #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edigaryev
reviewed
Mar 24, 2023
internal/command/worker/run.go
Outdated
| @@ -23,6 +26,8 @@ func newRunCommand() *cobra.Command { | |||
| } | |||
| cmd.PersistentFlags().StringVar(&bootstrapTokenRaw, "bootstrap-token", "", | |||
| "a bootstrap token retrieved via `orchard get bootstrap-token <service-account-name-for-workers>`") | |||
| cmd.PersistentFlags().StringVar(&logFilePath, "log-file", "/tmp/orchard-worker.log", | |||
There was a problem hiding this comment.
I don't think everyone wants to log to a file? IMO the standard output/error should be the default, as in Persistent Worker, for example.
There was a problem hiding this comment.
SGTM. See ed35e54
edigaryev
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a best practice. Inspired by https://github.com/uber-go/zap/blob/845ca51d5b8d9fed9fe14f35ab13b6b160d5762d/FAQ.md#does-zap-support-log-rotation