Introduce "create_grace_time" option #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Oct 6, 2022
| @@ -34,6 +35,13 @@ func (s *stepCreateVM) Run(ctx context.Context, state multistep.StateBag) multis | |||
| return multistep.ActionHalt | |||
| } | |||
|
|
|||
| if config.CreateGraceTime != 0 { | |||
There was a problem hiding this comment.
Should we always wait if that seems the case? Why we need to configure it? Or maybe set some default timeout?
There was a problem hiding this comment.
I don't think there's a golden value that we can hardcode for this racy situation. Some people might want it as short as possible, some might want it to be rather large to be on the safe side.
I'd suggest we leave as for now and see how well it works out in https://github.com/cirruslabs/macos-image-templates.
fkorotkov
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when invoking "tart run" straight after "tart create", the former may display a black screen. The culprit seems to be the
Virtualization.Framework, which still doesn't close the VM's files for some time after the Tart terminates:Solution: introduce an option that if specified, will force the Packer plugin to wait for the specified time after "tart create" finishes.