Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack in app structure #429

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Pack in app structure #429

merged 3 commits into from
Feb 28, 2023

Conversation

fkorotkov
Copy link
Contributor

This change makes homebrew installation to follow app-like structure so we can include embedded profiles for Bridged Network #243.

Unfortunetly, I wasn't able to figure out how to make a *.pkg do the same so I removed it. We have very little download count of the *.pkg file and IMO it's more important to get the Bridged network working.

I tested manually on my local machine all the steps like building the archive and creating a fake formula for testing. All parts seems working fine but I haven't figure out how to test everything together. I guess we can try to release, quickly test and revert back in case of issues.

Fixes #243

@fkorotkov
Copy link
Contributor Author

With a fresh head I figured out how to preserve building *.pkg. See 64a53a2

@fkorotkov fkorotkov merged commit 6311b8b into main Feb 28, 2023
@fkorotkov fkorotkov deleted the pack-in-app-structure branch February 28, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridged Network Support
2 participants