Allow to override VirtioFS tag for shared directories #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thumbs up! 😄 |
…734) * Simpler DirectoryShare parsing and --dir documentation improvements * Invert the argument.count logic to be similar to the old code For easier comparison. * Ensure we can parse /Users/admin/build:tag=foo-bar,ro * Document that options are comma-separated
edigaryev
approved these changes
Feb 19, 2024
fkorotkov
added a commit
to cirruslabs/gitlab-tart-executor
that referenced
this pull request
Mar 6, 2024
After introducing of cirruslabs/tart#733 we can use different VirtioFS tags for different directories and precisely mount them into exact locations. `/Volumes/My Shared Files/` default path is error-prone since some tools don't like whitespaces in paths. With this change directories will be directly mounted into `$HOME`. Fixes #64
edigaryev
pushed a commit
to cirruslabs/gitlab-tart-executor
that referenced
this pull request
Apr 2, 2024
* Mount directories directly into `$HOME` After introducing of cirruslabs/tart#733 we can use different VirtioFS tags for different directories and precisely mount them into exact locations. `/Volumes/My Shared Files/` default path is error-prone since some tools don't like whitespaces in paths. With this change directories will be directly mounted into `$HOME`. Fixes #64 * Fixed lint issue * Don't forget to `mkdir -p` * Introduce `mountPoint`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #730