Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netsniff-ng may be HUP'ed incorrectly if pre-existing PCAP files exist #34

Closed
mmguero opened this issue Jul 11, 2019 · 1 comment
Closed

Comments

@mmguero
Copy link
Collaborator

mmguero commented Jul 11, 2019

The pcap-capture/scripts/netsniff-roll.sh script which is executed in the context of the pcap-capture container is responsible for making sure that netsniff-ng is HUP'ed if the PCAP file it is writing to exceeds the value for the PCAP_ROTATE_MINUTES environment variable (the PCAP_ROTATE_MEGABYTES value is actually handled by netsniff-ng itself with the -F argument).

However, there is a bug in netsniff-roll.sh: if previous pcap files matching the file naming schema exist in the pcap upload directory, they will be detected and cause netsniff-ng to continuously roll.

I need to fix netsniff-roll.sh to only HUP netsniff-ng based on pcap files that have were created after the netsniff-ng process we are examining.

@mmguero mmguero added bug Something isn't working capture Relating to pcap-capture container labels Jul 11, 2019
mmguero added a commit that referenced this issue Jul 11, 2019
@mmguero
Copy link
Collaborator Author

mmguero commented Jul 11, 2019

Fixed with commit e9ccbfc

@mmguero mmguero closed this as completed Jul 11, 2019
mmguero added a commit that referenced this issue Jul 11, 2019
* Build DEB package for python3.7 rather than just make altinstall

* Updated build ISO process to create a package for python3.7 rather than just make altinstall

* working on making malcolm iso buster-based

* bump version to 1.3.1

* genericize gitignore

* enable net.ipv4.ip_forward for docker

* issue #34: don't HUP netsniff-ng based on PCAP files that predate the netsniff-ng process being examined

* remove development package required for pip before finishing docker build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant