Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the report module to handle policies with a list of items #526

Closed
Tracked by #696
buidav opened this issue Sep 7, 2023 · 4 comments
Closed
Tracked by #696

Update the report module to handle policies with a list of items #526

buidav opened this issue Sep 7, 2023 · 4 comments
Assignees
Labels
bug This issue or pull request addresses broken functionality
Milestone

Comments

@buidav
Copy link
Collaborator

buidav commented Sep 7, 2023

💡 Summary

update HTML

With the emerald release we are parsing the baseline markdown documents which has policies that contain bulleted lists.
The above image is what is currently happening to those bulleted lists when they appear in the report.

Goal of this issue is to update the Createreport.psm1 module to better display these lists.

Motivation and context

To make the Policy requirement readable in the report when there is a bulleted list.

Implementation notes

  • Updates to CreateReport.psm1
  • Possible updates to the reporter *.js and *.css files.

Acceptance criteria

A human can read the requirement of a policy with a list of items in the ScubaGear report.

@buidav buidav added the bug This issue or pull request addresses broken functionality label Sep 7, 2023
@schrolla schrolla added this to the Flipper milestone Sep 11, 2023
@isab-m isab-m assigned isab-m and unassigned isab-m Nov 13, 2023
@twneale twneale assigned twneale and unassigned twneale Jan 12, 2024
@twneale
Copy link
Collaborator

twneale commented Jan 12, 2024

Is this already fixed in the flipper branch? The bullets are showing up formatted in the exo report I just generated.

Image

@mitchelbaker-cisa mitchelbaker-cisa self-assigned this Jan 17, 2024
@mitchelbaker-cisa
Copy link
Collaborator

mitchelbaker-cisa commented Jan 17, 2024

Looking into this a bit further the overflow-wrap: break-word CSS property is applied to each <td> tag, which formats each bullet point to the next line.

Image

Another issue here is markdown formatting to bold text, (** bold text **) which should be formatted to <b> bold text </b>. See here for usage notes between <strong> vs, <b>

@schrolla
Copy link
Collaborator

Coordinate with @isab-m regarding work on report render that supports bolding and is in PR review now. May be overlap in PR #730 .

@schrolla
Copy link
Collaborator

Appeears to be handled in #604 . Closing as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

No branches or pull requests

6 participants