-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EXO code to align to revised emerald baseline #527
Update EXO code to align to revised emerald baseline #527
Conversation
Also addresses EXO half of #124. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Just two (hopefully) minor comments.
e757cc1
to
6a7c46a
Compare
6a7c46a
to
e9abd74
Compare
Baseline document updatesBased on the writing the automated functional tests for EXO, below are some baseline document updates that I noticed. Tagging @ahuynhMITRE and @schrolla for awareness.
|
4872db8
to
408967c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the EXO code extensively when writing the automated functional test YAML file. Bugs found have been added as separate issues. I also just added #571 based on a comment here.
@tkol2022 @Sloane4 3.1 #564 4.3 #562 4.4 #563 6.2 #560 7.1 #571 |
018a5e7
to
bc29ce6
Compare
9ea294c
to
fc7fb44
Compare
@nanda-katikaneni this is ready to merge |
* commit these changes first * fix unit tests * fix Policy group 6 check, improve error handling for policy 12, update unit tests * address feedback round 1 * fix dkim dmarc rua ruf fields * fix variable naming * more variable naming * get rid of m365 admin center instr * more unit tests * additional unit tests * address comments * force DMARC rdata to always be an array and fail if domain if NxDomain is returned * fix missing email in policy
* commit these changes first * fix unit tests * fix Policy group 6 check, improve error handling for policy 12, update unit tests * address feedback round 1 * fix dkim dmarc rua ruf fields * fix variable naming * more variable naming * get rid of m365 admin center instr * more unit tests * additional unit tests * address comments * force DMARC rdata to always be an array and fail if domain if NxDomain is returned * fix missing email in policy
🗣 Description
💭 Motivation and context
Closes #429
Additionally Resolves #562, #563, #564, #560, #571
Addresses the EXO half of #124. Teams half still needs to be addressed.
🧪 Testing
Tested on E5, G3, G5, GCC High Tenants.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist