Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#84] Detailed report message Gmail #278

Merged
merged 43 commits into from
Jun 3, 2024
Merged

Conversation

snarve
Copy link
Collaborator

@snarve snarve commented May 9, 2024

🗣 Description

This PR covers adding the Detailed report message feature for Gmail and also the Group override policy.
Gmail policies cannot be controlled at Group level, so no changes there
Also, covered in this PR, updates to the rego code to refer to the updated 'FilterEventsOU'

💭 Motivation and context

Closes #84 , #197

🧪 Testing

  • Ensure the report results are as expected for Gmail policies
  • All unit tests should pass

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@snarve snarve added this to the Barracuda milestone May 9, 2024
@snarve snarve self-assigned this May 9, 2024
@snarve snarve linked an issue May 9, 2024 that may be closed by this pull request
rego/Gmail.rego Outdated Show resolved Hide resolved
rego/Gmail.rego Outdated Show resolved Hide resolved
rego/Gmail.rego Outdated Show resolved Hide resolved
rego/Gmail.rego Outdated Show resolved Hide resolved
rego/Gmail.rego Outdated Show resolved Hide resolved
rego/Gmail.rego Outdated Show resolved Hide resolved
rego/Gmail.rego Outdated Show resolved Hide resolved
rego/Gmail.rego Outdated Show resolved Hide resolved
rego/Gmail.rego Show resolved Hide resolved
rego/Gmail.rego Outdated Show resolved Hide resolved
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this earlier, there are few more instances where the wording used in the details message matches the API language instead the of language used in the baseline/UI.

rego/Gmail.rego Outdated Show resolved Hide resolved
rego/Gmail.rego Outdated Show resolved Hide resolved
rego/Gmail.rego Outdated Show resolved Hide resolved
rego/Gmail.rego Outdated Show resolved Hide resolved
@snarve snarve requested review from buidav May 31, 2024 05:42
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes my quick smoke test but have some comments about the rider commits

rego/Chat.rego Outdated Show resolved Hide resolved
rego/Calendar.rego Outdated Show resolved Hide resolved
Copy link
Collaborator

@LaurenBassett LaurenBassett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Want to figure out why those two comments are deleted before merging but everything else looks fine

@adhilto adhilto merged commit a6afc84 into main Jun 3, 2024
9 checks passed
@adhilto adhilto deleted the 84-detailed-report-message-gmail branch June 3, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detailed Report message - Gmail
4 participants