-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#84] Detailed report message Gmail #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this earlier, there are few more instances where the wording used in the details message matches the API language instead the of language used in the baseline/UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes my quick smoke test but have some comments about the rider commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. Want to figure out why those two comments are deleted before merging but everything else looks fine
🗣 Description
This PR covers adding the Detailed report message feature for Gmail and also the Group override policy.
Gmail policies cannot be controlled at Group level, so no changes there
Also, covered in this PR, updates to the rego code to refer to the updated 'FilterEventsOU'
💭 Motivation and context
Closes #84 , #197
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and merge
button.✅ Post-merge Checklist